infra: serve install.sh from site root#163
Merged
Merged
Conversation
Mirrors the portal's download-redirected-files.sh pattern: a postbuild script fetches the ICP SDK installer from the sdk public-manifest branch and places it at dist/install.sh so it is served at /install.sh. Required because internetcomputer.org/install.sh now redirects to docs.internetcomputer.org/install.sh and we were returning 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postbuildnpm script that downloads the ICP SDK installer from the SDK `public-manifest` branch and places it at `dist/install.sh`Problem
`internetcomputer.org/install.sh` now redirects to `docs.internetcomputer.org/install.sh`. We were returning 404, breaking `curl -sL https://internetcomputer.org/install.sh | sh` for anyone installing the SDK.
Approach
Mirrors the portal's `download-redirected-files.sh` pattern exactly:
The file is fetched fresh on every build so it always tracks the latest SDK release. The `icp-cli-installer.sh` on icp-cli releases was considered but the portal sources from `dfinity/sdk` — kept consistent.
Sync recommendation
`informed by dfinity/portal — download-redirected-files.sh`